Hi Erik.
I tested your cleanup in s5k83a init sequence today. It work fine in all my
test (after clean boot, reboot, resume from suspend (s2ram) and resume from
hibernate (s2disk)).
I found small, but dangerous error in s5k83a init function during tests. This
error set incorrect default ctl values after init. In attachment is patch for
fix this.
By the way, I look up to your pertinacity. All respect!
Regeards, Lukas
--- m5602_s5k83a.c.old 2009-01-20 19:15:25.000000000 +0100
+++ m5602_s5k83a.c 2009-01-21 15:05:27.000000000 +0100
@@ -199,7 +199,7 @@
int s5k83a_init(struct sd *sd)
{
int i, err = 0;
- s32 *sensor_settings = sd->sensor_priv;
+ s32 *sensor_settings = ((struct s5k83a_priv*)sd->sensor_priv)->settings;
for (i = 0; i < ARRAY_SIZE(init_s5k83a) && !err; i++) {
u8 data[2] = {0x00, 0x00};
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
M560x-driver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/m560x-driver-devel
