Hi,
Great work !
If you have already replaced character formatting with system Font
Dialog it's excellent !
I ll try your patch asap.
Cu,
Sebastien
PS : on peut se retrouver à midi un de ces jours sur l'INSA à la KFet si
ca te dis, histoire de continuer dans la real life notre collaboration
sur OO.
Pavel Janík a écrit :
Hi,
As i explained on my blog, i have been working on native windows: i
added new types of aqua windows like utility windows or sheets.... I
have made window usage more aqua.
The patch is at:
http://lebasket.free.fr/OOo/07_03_07/patchWindows07_03_07.diff
This patch concerns the aqua part of vcl but also the platform
independent part.
This patch is still experimental.
I have read it and tried it.
In general: I like how it changes window displaying. Having e.g.
Styles and Formatting as utility window is the right way to go and
modal dialogs displayed as sheets is also the right way. I like it ;-)
I have minor nits though:
- first the compilation related ones:
../../../aqua/inc/salframe.h: In constructor
'AquaSalFrame::AquaSalFrame(SalFrame*, ULONG, AquaSalInstance*)':
../../../aqua/inc/salframe.h:89: warning:
'AquaSalFrame::mnBackgroundBrush' will be initialized after
../../../aqua/inc/salframe.h:86: warning: 'AquaSalInstance*
AquaSalFrame::mpSalInstance'
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/window/salframe.cxx:120:
warning: when initialized here
Please keep initializations in constructor ordered, otherwise compiler
will warn about it:
mpSalInstance(pSalInstance),
mbDialog(FALSE),
mnBackgroundBrush(0),
I wondered what the number 14 is, so:
- fprintf(stderr, "%d\n", style);
+ fprintf(stderr, "Style: %d\n", (int) style);
- I think we can add some new flags to the generic VCL part but it has
to be very clean - Mac OS X parts ifdefed for MACOSX/QUARTZ, the
behaviour for other platforms unchanged etc. (this is about last two
hunks in your patch).
--Pavel Janík
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
