HI,

Ismael, you are correct.  I will try to merge the two.

Thank you,

Mike


On Mar 13, 2007, at 4:05 PM, Ismael wrote:

Hi,
Concerning drawAlphaRect, Damien implemented this functions some time ago, but hasn't commited it yet.

I read your patch Michael, and some things have to be changed/ corrected. For example, for the transparency you use: 1.0f/ nTransparency, but according to the win32 implementation, nTransparency is between 0 and 255, so here's what we have to do: ((float)(255-nTransparency)/255) because the OOo transparency value of 0 corresponds to the quartz transparency value of 1, and the OOo transparency value of 255 corresponds to the quartz transparency value of 0. Also, in your patch it seems that you don't use the current fill color value (which belongs to the aquasalgraphics class). I propose that you merge your patch with damien's because these 2 patches have both good things and uncompleted parts that are completed by the other patch.

Here's damien patch: http://lebasket.free.fr/OOo/09_03_07/ patch03_03_07InvertAlphaRect.diff

Ismael MERZAQ

Michael Sicotte a écrit :
Hi Eric,
Here is a link -
http://www.mikesicotte.com/patch/drawAlphaRect_salgdi.cxx.diff
Thanks,
Mike
On Mar 13, 2007, at 12:29 PM, eric b wrote:
Hi Michael,


I noticed in the console that RefreshRect is called sometimes when there is not a valid mrView, and also that drawAlphaRect was not implemented.


Yes, indeed.

So I have created a patch that addresses these issues.


Thanks :)


It is attached.  Check it out if you have some time.


Hmmm  ... no, it isn't attached


Maybe because we have stu^^^strong anti-viruses filtering mails ;)


Eric


-------------------------------------------------------------------- -
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to