Hi Stephan,

On Wed, Mar 19, 2008 at 12:01:51PM +0100, Stephan Bergmann wrote:
> >>>>(There are two further breaks in that tinderbox build.  One is desktop, 
> >>>>which has been fixed on the CWS in the meantime.  The other is some 
> >>>>setlocale stuff in vcl, 
> >>>><http://tinderbox.go-oo.org/gunzip.cgi?tree=sb83&brief-log=1205767802.29103#err55>,
> >>>> 
> >>>>and I assume it is not related to the CWS.)
> >>>Hmm - as this as well doesn't happen in any other cws or master, this
> >>>might still be a side-effect of the cws, same with the autodoc one.
> >>Right, it is probably related to using the compiler's C++ library 
> >>instead of STLport.  I now get errors ("[Tue Mar 18 09:08:52 2008] 
> >>gunzip.cgi: tree: sb83 does not exist") when I try to access the 
> >>tinderbox status, so I have currently no idea how to address this.
> 
> This might be caused by solenv/inc/unxmacx.mk:1.22.14.6 l. 55--57
> 
> .IF "$(GUIBASE)"=="unx"
> CDEFS+= -DX_LOCALE
> .ENDIF
> 
> (whatever that is supposed to be good for). 

Was introduced here:
http://tools.openoffice.org/source/browse/tools/solenv/inc/unxmacxp.mk?r1=1.45&r2=1.45.14.1
(before the common unxmacx.mk was created) - ooo111fix2 cws with
internal issue 111934
That change is four years old. lxr didn't return any occurences of
X_LOCALE except for the makefile, grep -rI X_LOCALE * in solver & vcl didn't
return anything either. SO I wonder how that could cause a problem,
but...

> Could anybody verify that a 
> CWS sb83 based (i.e., --without-stlport), X11 (i.e., --with-x) build 
> succeeds when those three lines are dropped?

...commented-out the lines above and rebuilt vcl in the existing build tree
-> build succeeded. 
So yes, this is the cause, and since it appears to be used nowhere (?)
it should be safe to remove completely - at least from the global flags.

The only occurence I found is in /usr/include/X11/Xlocale.h
#ifndef X_LOCALE
#include <locale.h>
#else

ciao
Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to