On Fri, Feb 6, 2009 at 12:35 PM, amical <[email protected]> wrote: > > Ted: > > I noted in the original post that I tried to execute just before the > "Custom Icons" were edited in. It failed.
Not for me. > > I finished the Tutorial edits and merged all of your "working" > filechanges into mine except for Filesystem.m (too much and I won't > risk a merge). > > I guess my bottom line is: sample code used to show capability "A" > should not have any other "optional" or obsolete stuff in it. KISS. > The exercise is a good one, just trim it down so it has the bare > minimum code. Create another (Ver 2) if you want to expand and > demonstrate more features & capabilities. It has the bare minimum code to show off the capabilities that I wanted to show. There is no optional or obsolete code in there. The file system templates try to help you by creating stubs for all of the delegate methods that your file system might use. In the context of the tutorial, some of them are optional so it is noted that they may be removed if you desire. The absolute bare minimum example is to use a file system template and do nothing else. That gives you an "empty" file system. That isn't very interesting, however. > > > General suggestions & feedback: > > Requirements: > 3. "Check out the helper files ..." > need a date or revision to be sure it is the current one That is a good idea, but in this case I explicitly want people to check out the head of the tree. Before I updated the tutorial for MacFUSE 2.0 I had the user checking out a tag. If we get to the point where the tutorial may be broken then I will switch it back to a specific 2.x tag. > 3. "... you can do all the work in your /tmp directory" > ~/tmp would be better - avoid multi-user clashes ~/tmp does not exist by default on OS X. > > Time To Code: > would be better if the edit points were better noted, either with a > comment marker or a few lines of context around the change. It is a bit difficult to do that with the editing tool. I changed some of the text to mention "edit" and "change" to indicate that the method should be edited rather than added since in many cases we are editing the stubs. > > I would also place "Build & Go" markers in the Tutorial and show a > sample of expected output - good and bad. Not a bad idea. I'll try to grab some screenshots if I get a chance. The output is really a picture of the Finder window, for the most part. > > Below are the code diffs except for Filesystem.m (too much for the > forum unless you want it). > If you want more - ping me. Thanks. I know about the code diffs. I don't think they are as large as you make it out to be. For the most part, the diffs in YTFS_Controller.m would be accounted for: 1) I placed the init routines at the bottom while I recommended putting them at the top in the tutorial. I think I'll probably change this in the final code, since it really doesn't matter. I put them at the bottom in case people skipped the tutorial altogether; I wanted to emphasize the file system part and not the initialization of YouTube video data. 2) I followed the optional "Remove Unused Delegate Selectors" section. Thanks for the input and best of luck with your file system. ted > > regards, > mt > > > Current Source diffs: > > All files: Comments & whitespace diff's are ignored > > main.m, YTFS_Prefix.pch YTFS_Controller.h > no change > > > YTFS_Controller.m: > 35a50,54 >> // Pump up our url cache. >> NSURLCache* cache = [NSURLCache sharedURLCache]; >> [cache setDiskCapacity:(1024 * 1024 * 500)]; >> [cache setMemoryCapacity:(1024 * 1024 * 40)]; >> > > > YTFS_Filesystem.h: > 11a26,27 >> @class YTVideo; >> > 19a36 >> - (YTVideo *)videoAtPath:(NSString *)path; > > > YTFS_Filesystem.m: > 8,9d21 > < #import <sys/xattr.h> > < #import <sys/stat.h> > ### too much to list ### > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MacFUSE" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/macfuse?hl=en -~----------~----~----~----~------~----~------~--~---
