Hi

Yes, we are trying to get the HAL side of Machinekit as generic as possible, there is a lot more could be done aside from CNC machine control.

If you fork machinekit, clone to your computer and then create a suitably named branch and put your driver in https://github.com/machinekit/machinekit/tree/master/lib/python/drivers, that should be about right.

Would like to see a document or example config which shows it's use too.
If a short doc, it can go in the same directory, if a full config, needs a suitable entry in https://github.com/machinekit/machinekit/tree/master/configs
exact placement depending upon whether it requires specific machine / hardware etc.
Looks like there is unlikely to be a sim, as it should require hardware present?

The python string on line one, should specify python2.
This is so that distros that ship with python3 as default can build without problems.

As for licence, GPL2 is fine
A general boiler plate would be

# This is             a HAL component to                            
# Copyright date name <email>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA


Then push your new branch back to your fork, and create a pull request from your fork of machinekit in github, to machinekit / machinekit
and we will check it, test build and authorise.

If that is beyond your current experience curve, then reply direct when you have your fork with the relevant files in and I will talk you through it

regards


On 24/05/18 01:50, Karl Nilsson wrote:
Hello All,
  A while back, I created a HAL component for interfacing thermocouple amplifiers over the SPI bus (specifically the MAX31855 and MAX6675). I was curious whether there was any interest in including it in machinekit proper, and if so, what do I need to do in order to get it included. Specifically, is there any preferred copyright license for user-contributed components?

Here's the code, feedback is appreciated!
--
website: http://www.machinekit.io blog: http://blog.machinekit.io github: https://github.com/machinekit
---
You received this message because you are subscribed to the Google Groups "Machinekit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
Visit this group at https://groups.google.com/group/machinekit.
For more options, visit https://groups.google.com/d/optout.

--
website: http://www.machinekit.io blog: http://blog.machinekit.io github: https://github.com/machinekit
---
You received this message because you are subscribed to the Google Groups "Machinekit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
Visit this group at https://groups.google.com/group/machinekit.
For more options, visit https://groups.google.com/d/optout.

Reply via email to