Hello Brent,
The build changes look pretty good. Just one nit, in the new
LibosxLibraries.gmk, please remove the "include LibCommon.gmk" as that
is now handled by Lib-java.desktop.gmk.
/Erik
On 2016-03-01 22:16, Brent Christian wrote:
Hi,
A number of internal APIs were carried over into the JDK with the
Apple port. Among them was com.apple.concurrent.Dispatch.
Supportedness has always been murky here, but Jigsaw necessitates a
firmer stance. Some of these APIs have already been removed from JDK
9 [1], some will be supplanted by new, supported APIs [2].
As already discussed in [3] and [4], com.apple.concurrent.Dispatch is
no longer in use, as far as we've been able to find.
com.apple.concurrent.Dispatch and its supporting code should be
removed from JDK 9.
It turns out this opens the door for a little module pruning as well.
com.applet.concurrent makes up the bulk of the jdk.deploy.osx module.
All that's left is native code for libosx, a library relied on by
com.apple.eio.FileManager in the java.desktop module. By moving
libosx over to java.desktop, we are able to do away with the
jdk.deploy.osx module altogether.
For your review is a webrev of this change:
http://cr.openjdk.java.net/~bchristi/8148187/webrev.01/
JBS: https://bugs.openjdk.java.net/browse/JDK-8148187
Automated build+test runs look fine.
If, in the future, there is desire for an ExecutorService backed by
the native platform (as com.apple.concurrent.Dispatch does for
libdispatch on OS X), such a feature could be proposed.
Thanks,
-Brent
1. "Remove apple script engine code in jdk repository"
https://bugs.openjdk.java.net/browse/JDK-8143404
2. JEP 272 : "Platform-Specific Desktop Features"
https://bugs.openjdk.java.net/browse/JDK-8048731
3.
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2015-May/006934.html
4.
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2015-September/006968.html
