> On Jun 29, 2016, at 6:47 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > >> >> On Jun 29, 2016, at 12:36 PM, Brent Christian <brent.christ...@oracle.com> >> wrote: >> >> Hi, >> >> Please review the following change for JDK 9: >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8160370 >> Webrev: >> http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/ >> >> The fix for 7131356 fills in the "os.version" system property on Mac using >> [NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9. >> >> While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all >> testing infrastructure has been updated, and we've seen failures of >> >> java/lang/System/OsVersionTest.java >> >> The code to restore behavior on older Mac systems is only a few lines, so >> that seems like a good way to get testing going again. > > I think we should move away from testing on unsupported platforms. Is this > just temporary? when will this be removed?
I think we should leave the workaround code in forever - it will never execute on newer/supported OS X and will do the right thing on earlier ones. cheers
