On Feb 16, 2007, at 12:45 PM, Sbranzo wrote:
Just a head-up for a new port submitted a while ago:
http://trac.macports.org/projects/macports/ticket/11299
Gufo
From my comment in the ticket:
Committed in r22124, thanks for the contribution! Notes of interest:
1) "revision" defaults to zero, so no need to state it explicitly if
that's the value used.
2) Number of files should be kept to a minimum, so a patch like that is
unnecessary as users using the port are already using MacPorts, no need
to instruct them to type port install to install the software.
3) No need to pass --prefix=${prefix} to the configure script, that's
basically what MacPorts is for ;-)
4) Don't hardcode /opt/local in the Portfile, that's the default value
of ${prefix} but users are free to choose another one; Portfile should
be abstracted from explicit values as much as possible.
Other than that, great work, keep those contributions coming!
-jmpp
PS: Ticket severity should not be Crash/Data loss ;-)
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev
