On Nov 15, 2007, at 02:29, [EMAIL PROTECTED] wrote:

Revision: 31068
          http://trac.macosforge.org/projects/macports/changeset/31068
Author:   [EMAIL PROTECTED]
Date:     2007-11-15 00:29:39 -0800 (Thu, 15 Nov 2007)

Log Message:
-----------
Add pidgin-encryption from trac tickets #13311

Added Paths:
-----------
    trunk/dports/net/pidgin-encryption/
    trunk/dports/net/pidgin-encryption/Portfile

Added: trunk/dports/net/pidgin-encryption/Portfile
===================================================================
--- trunk/dports/net/pidgin-encryption/ Portfile (rev 0) +++ trunk/dports/net/pidgin-encryption/Portfile 2007-11-15 08:29:39 UTC (rev 31068)
@@ -0,0 +1,29 @@
+# $Id$
+PortSystem     1.0
+name           pidgin-encryption
+version                3.0
+categories     net
+maintainers    [EMAIL PROTECTED]
+description    Pidgin encryption plugin
+depends_lib    port:nss port:pidgin
+
+long_description ${description}
+configure.args --prefix=${prefix} \

No need to say "--prefix=${prefix}"; MacPorts includes that in configure.pre_args automatically for all ports.

+               --with-nss-includes=${prefix}/include/nss \
+               --with-nss-libs=${prefix}/lib \
+               --with-nspr-includes=${prefix}/include/nspr \
+               --with-nspr-libs=${prefix}/lib
+               
+homepage       http://pidgin-encrypt.sourceforge.net/
+master_sites   http://downloads.sourceforge.net/pidgin-encrypt/

I think "master_sites sourceforge" would be sufficient, wouldn't it?

+checksums pidgin-encryption-3.0.tar.gz md5 3f3f8e9a15d19e084d54bfbbd2db9d77


No need to say the distfile name, if this is the only file being downloaded. Just do "checksums md5 3f3f8e9a15d19e084d54bfbbd2db9d77".

+worksrcdir      ${worksrcpath}

What's this for?

+build {system "cd ${worksrcdir} && make"}

What was unsatisfactory about the usual build command?

+destroot {
+        xinstall -m 755 -d ${destroot}${prefix}/lib/pidgin/

No need to say "-m 755"; that's the default for directories anyway.

+ eval xinstall -m 755 ${worksrcpath}/.libs/encrypt.so $ {destroot}${prefix}/lib/pidgin/ + eval xinstall -m 755 ${worksrcpath}/.libs/encrypt.la $ {destroot}${prefix}/lib/pidgin/
+}

Why "eval"? This could be more easily written as a single command, right?

xinstall -m 755 -W ${worksrcpath}/.libs encrypt.so encrypt.la $ {destroot}${prefix}/lib/pidgin

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to