I agree it's an awkward scenario; those changes were actually a user submitted patch, but I reviewed and considered the issues you're pointing out.
While it's impossible to anticipate all usecases, it seems that Sphinx's userbase is almost entirely mysql-exclusive, so the general ideas in that patch are likely the correct. I'm about to push an updated version, but obviously supporting all possible variants (mysql5, mysql5+postgresql83, postgresql83 by itself, etc) is both impractical and silly. I'll monitor feedback about the port, and try to make sure it's meeting the actual users needs. b On Sep 29, 2008, at 23:16 , Ryan Schmidt wrote: > > On Sep 29, 2008, at 11:19 AM, [EMAIL PROTECTED] wrote: > >> Revision: 40328 >> http://trac.macports.org/changeset/40328 >> Author: [EMAIL PROTECTED] >> Date: 2008-09-29 09:19:58 -0700 (Mon, 29 Sep 2008) >> Log Message: >> ----------- >> add postgresql83 option for sphinx >> >> Modified Paths: >> -------------- >> trunk/dports/textproc/sphinx/Portfile >> >> Modified: trunk/dports/textproc/sphinx/Portfile >> =================================================================== >> --- trunk/dports/textproc/sphinx/Portfile 2008-09-29 16:19:35 UTC >> (rev 40327) >> +++ trunk/dports/textproc/sphinx/Portfile 2008-09-29 16:19:58 UTC >> (rev 40328) >> @@ -20,6 +20,7 @@ >> distfiles sphinx-${version}.tar.gz >> checksums sha1 0f82e56a9181b3aeaeef65e9ba82fbf6fbe632d6 >> >> +depends_lib-append port:mysql5 >> configure.args --mandir=${prefix}/share/man \ >> --datadir=${prefix}/share/doc \ >> --with-mysql-includes=${prefix}/include/mysql5/mysql \ >> @@ -27,9 +28,17 @@ >> >> test.run yes >> >> -variant postgres description {Enable PostgeSQL support} { >> +variant postgres description {Enable PostgreSQL support for old >> PgSQL 8.2} { >> depends_lib-append port:postgresql82 >> configure.args-append --with-pgsql >> configure.args-append --with-pgsql-includes=${prefix}/include/ >> postgresql82 >> configure.args-append --with-pgsql-libs=${prefix}/lib/ >> postgresql82 >> } >> + >> +variant postgresql83 description {Enable PostgreSQL support for >> newer PgSQL v8.3} { >> + depends_lib-append port:postgresql83 >> + configure.args-append --with-pgsql >> + configure.args-append --with-pgsql-includes=${prefix}/ >> include/postgresql83 >> + configure.args-append --with-pgsql-libs=${prefix}/lib/ >> postgresql83 >> + configure.args-delete --with-mysql-includes >> +} > > Is this correct? > > You added a global mysql5 dependency which seems to match with the > global --with-mysql-includes configure argument. But in the > postgresql83 variant you delete the configure argument but don't > delete the dependency? And in the postgres variant you don't delete > either of them. > > > > !DSPAM:48e1c3e0299683780313872! > _______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
