On Oct 19, 2008, at 07:39, Rainer Müller wrote:

> Ryan Schmidt wrote:
>
>> It builds only on 10.5? or it builds on 10.5 or greater? If the
>> latter, I recommend something like:
>>
>> variant aqua description {Build Aqua front-end} {
>>      pre-fetch {
>>              if { ${os.major} < 9 } {
>>                      return -code error "The aqua front-end of ${name} 
>> requires Mac OS
>> X 10.5 or greater. Try the gtk variant instead."
>>              }
>>      }
>>      configure.args-delete   --disable-darwin
>>      configure.args-append   --enable-darwin
>> }
>
> Okay, moving this into the aqua variant is better. But you missed the
> platform check on ${os.platform}.

I didn't so much miss it as just left it out. :) "Aqua" implies Mac  
OS X anyway. So if anything, you'd want to throw a fatal error if the  
user attempts to use the +aqua variant and is not running Mac OS X.

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to