On Dec 1, 2008, at 16:16, Bryan Blackburn wrote:
On Mon, Dec 01, 2008 at 10:06:22AM -0800, [EMAIL PROTECTED] said:Revision: 42862 http://trac.macports.org/changeset/42862 Author: [EMAIL PROTECTED] Date: 2008-12-01 10:06:21 -0800 (Mon, 01 Dec 2008) Log Message: ----------- Upgrade port to gst v3.1 Modified Paths: -------------- trunk/dports/lang/gst/Portfile Modified: trunk/dports/lang/gst/Portfile[...]-maintainers landonf openmaintainer +maintainers [EMAIL PROTECTED]Did you mean to drop Landon as a maintainer?
I noticed that too, and also this:
+default_variants +gtk +tcltk + +variant gtk { + depends_lib-append port:gtk2 + configure.args-append --enable-gtk +} + +variant tcltk { + depends_lib-append port:tcl port:tk + configure.args-append --with-tk --with-tcl +} + +variant nox conflicts gtk conflicts tk { + configure.args-append \ + --without-x \ + --disable-gtk \ + --without-tk \ + --without-tcl +}
The variant to disable X11 support should be called no_x11, not nox.The nox variant is marked as conflicting with tk but there is no valiant called tk. Did you mean tcltk?
You shouldn't use the conflicts word twice in a single variant declaration; just list all the conflicting variants after the word "conflicts".
gtk and tcltk should only be made the defaults if the user has not already chosen to disable X11.
Attached is my initial pass at fixing this. However there remain these questions:
What is the relationship between these variants? Is there ever a case when one would want to disable the gtk or tcltk variants? If so, it will be difficult for a user to do so, due to a long-standing MacPorts base bug which makes it so that if you install a port with negative variants (sudo port install gst -gtk -tcltk) and then upgrade it (sudo port upgrade gst), the deselected variants will be added again. Perhaps the variants should be changed to no_gtk and no_tcltk. Is there ever a case when a user would want to select neither gtk nor tcltk nor no_x11?
Also, the variants need descriptions.
gst.diff
Description: Binary data
_______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
