On Feb 11, 2009, at 09:19, Orville Bennett wrote:

On Feb 11, 2009, at 9:31 AM, Jean-Michel Pouré wrote:

I have a applied a patch on libiconv, which works fine, but cannot find
the ticket. Is this still open:

Index: textproc/libiconv/Portfile
===================================================================
--- textproc/libiconv/Portfile  (revision 46735)
+++ textproc/libiconv/Portfile  (working copy)
@@ -5,7 +5,7 @@

name                    libiconv
version                 1.12
-revision                2
+revision                3
categories              textproc
maintainers             ryandesign
platforms               darwin freebsd linux
@@ -54,6 +54,11 @@
    --disable-nls \
    --enable-extra-encodings

+post-patch {
+    # make iconv prototype the same on all platforms
+    reinplace "s|am_cv_proto_iconv_arg1=\"const\"|
am_cv_proto_iconv_arg1=\"\"|" ${worksrcpath}/configure
+}
What, exactly, does this do? And why is it needed?

I believe that is the patch mentioned here to make the libiconv function prototype always POSIX compliant:

http://trac.macports.org/ticket/18258#comment:22

http://trac.macports.org/attachment/ticket/18258/Portfile.diff

And I believe that conflicts with the wishes of the developer of libiconv so I do not intend to apply such a patch to the portfile:

http://trac.macports.org/ticket/18440



_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to