On Mar 11, 2009, at 16:29, [email protected] wrote:

Revision: 47969
          http://trac.macports.org/changeset/47969
Author:   [email protected]
Date:     2009-03-11 14:29:23 -0700 (Wed, 11 Mar 2009)
Log Message:
-----------
jpeg: Prevent linker from finding wrong library and header files.
Fixes #16411 (maintainer timeout).
Revision not increased because the library should have built correctly or not at all.

Modified Paths:
--------------
    trunk/dports/graphics/jpeg/Portfile

Modified: trunk/dports/graphics/jpeg/Portfile
===================================================================
--- trunk/dports/graphics/jpeg/Portfile 2009-03-11 21:26:37 UTC (rev 47968) +++ trunk/dports/graphics/jpeg/Portfile 2009-03-11 21:29:23 UTC (rev 47969)
@@ -40,6 +40,14 @@
 post-patch {
     system "cd ${worksrcpath} &&
         tar zxf ${distpath}/droppatch.tar.gz"
+
+ # Reorder link flags so that so that local -L options come first (especially before -L${prefix}/lib)
+    #     (see http://trac.macports.org/ticket/16411).
+ reinplace "s|\\(.*\\)\\(\$(LDFLAGS)\\)\\(.*\\)\\(\$(LDLIBS)\\)\ \(.*\\)|\\1\\4\\3\\2\\5|" ${worksrcpath}/makefile.cfg

This is hard to decipher. Could it be implemented as a patchfile instead, or would that be huge?

+ # As in the case of -L, CPPFLAGS come before -I. during compilation.
+    configure.cppflags-append -isystem${prefix}/include
+    configure.cppflags-delete -I${prefix}/include

What is the story behind using -isystem instead of -I? Where does that come from?

Is this a change that would be useful generally? Should MacPorts base do this?


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to