On Mar 27, 2009, at 13:15, Eric Hall wrote:

On Fri, Mar 27, 2009 at 06:23:33AM -0500, Ryan Schmidt wrote:
On Mar 27, 2009, at 06:19, Ryan Schmidt wrote:

Wouldn't you say that no port should ever override the checksum
phase? If there are distfiles, their checksums must be validated,
and if there are no distfiles, then the checksum phase won't get
run anyway.

Same with the extract phase.

Same with the fetch phase.


$ grep '^fetch[[:space:]]*{[[:space:]]*}' */*/Portfile
databases/postgresql80-server/Portfile:fetch    {}
databases/postgresql81-server/Portfile:fetch    {}
databases/postgresql82-server/Portfile:fetch    {}
databases/postgresql83-server/Portfile:fetch    {}

[snip list of ports...]

        Some of the ports listed don't have any files
they download and install, for example the postgres8?-server
ports create the user+group and startup item for the
DB engine, the dependency (port:postgresql8?) installs
all of the files, etc.  Thus the NULL fetch, checksum, etc.
phases are valid for these ports.  Is there a better way
to indicate that the ports don't have anything to fetch, etc.?

I would hope *all* the listed ports don't have any files, hence the reason for them overriding those phases. However that is not the method I want people to use. Instead, the distfiles variable should be cleared. (Put the word "distfiles" on a line of the portfile by itself.) If the port doesn't have any distfiles, then there's nothing for the fetch, checksum and extract phases to do and you don't need to override them.


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to