On Oct 5, 2009, at 09:11, [email protected] wrote:

Revision: 58794
         http://trac.macports.org/changeset/58794
Author:   [email protected]
Date:     2009-10-05 07:11:40 -0700 (Mon, 05 Oct 2009)
Log Message:
-----------
get the requested archs right

Modified Paths:
--------------
   trunk/dports/_resources/port1.0/group/archcheck-1.0.tcl

Modified: trunk/dports/_resources/port1.0/group/archcheck-1.0.tcl
===================================================================
--- trunk/dports/_resources/port1.0/group/archcheck-1.0.tcl 2009-10-05 12:53:54 UTC (rev 58793) +++ trunk/dports/_resources/port1.0/group/archcheck-1.0.tcl 2009-10-05 14:11:40 UTC (rev 58794)
@@ -45,10 +45,10 @@
default archcheck.files {}

pre-extract {
-    if {[variant_isset universal]} {
-        set requested_archs ${universal_archs}
+    if {[variant_exists universal] && [variant_isset universal]} {
+        set requested_archs ${configure.universal_archs}
    } else {
-        set requested_archs ${build_arch}
+        set requested_archs ${configure.build_arch}
    }
    foreach file ${archcheck.files} {
        # Prepend prefix if necessary.

Mmm, yes, because the port might modify configure.build_arch or configure.universal_archs, right? But the port can't modify build_arch or universal_archs?

What's the significance of checking [variant_exists universal]? If the variant doesn't exist, then [variant_isset universal] will be false, won't it? Or does it cause some kind of exception to check whether a nonexistent variant is set?


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to