On Oct 8, 2009, at 11:08, [email protected] wrote:
Revision: 59018
http://trac.macports.org/changeset/59018
Author: [email protected]
Date: 2009-10-08 09:08:03 -0700 (Thu, 08 Oct 2009)
Log Message:
-----------
update kdeedu4 to version 4.3.2 (#21912)
Modified Paths:
--------------
trunk/dports/kde/kdeedu4/Portfile
+patchfiles byteswap-osx.patch
+patch.dir ${workpath}/${distname}
+patch.pre_args -p1
I was all ready to explain how "${workpath}/${distname}" is more
simply known as "${worksrcpath}", and that that's the default for
patch.dir [1], but I see that's not the case for the kde4 portgroup
because it sets worksrcdir to "build". That's probably never right for
patching, as you're seeing. Maybe it would be smart to update the kde4
portgroup and either set the patch.dir there, or perhaps even better,
don't override the worksrcdir in the first place, and instead, just
override the configure.dir and build.dir.
[1] http://guide.macports.org/#reference.phases.patch
configure.args-append ../${distname}
I've found this a strange line before, and noted it's in every port
using the kde4 portgroup. Therefore, I suggested before it should be
moved to the kde4 portgroup as well (where it could use
configure.post_args-append so as not to interfere with
configure.args). Or perhaps all that's needed is to not override
configure.dir, and just set build.dir, as suggested above. Any
thoughts on whether that would work?
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
