Just a personal preference for regular expressions over patches.

Le 19 mars 2010 à 11:19, Ryan Schmidt a écrit :

> 
> On Mar 17, 2010, at 17:16, [email protected] wrote:
> 
>> Revision: 64928
>>         http://trac.macports.org/changeset/64928
>> Author:   [email protected]
>> Date:     2010-03-17 15:16:49 -0700 (Wed, 17 Mar 2010)
>> Log Message:
>> -----------
>> Create new variant no_gnome and fix a source typo in gvfs
> 
> 
>> +post-patch {
>> +    reinplace s/(unix)/(is_unix)/ ${worksrcpath}/daemon/gvfsftpdircache.c
>> +}
> 
> Wouldn't this fix be better carried out as a patchfile? There's only one 
> occurrence of the string "(unix)" to be replaced so I don't understand why 
> use a reinplace.
> 
> 

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to