On Jan 31, 2011, at 09:45, Vincent Lefevre wrote:
> On 2011-01-30 13:25:23 +1100, Joshua Root wrote:
>> While I'm sure this works, setting distname to "." doesn't really make
>> sense. If anything you'd want to set worksrcdir, but really you probably
>> want to set 'extract.mkdir yes' instead.
>> 
>> Also, instead of setting distfiles with a hardcoded version, consider
>> doing something like 'distname ${name}-[string map {. ""} $version]'.
> 
> Thanks. I've committed your suggestions. BTW, if setting distname to "."
> is discouraged, perhaps "port lint" could detect this.

Perhaps, but this is the first time I've ever seen anyone try to do that :P




_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to