Am 09.08.11 16:34, schrieb Ryan Schmidt:
On Aug 8, 2011, at 18:25, Christoph Iserlohn wrote:

Am 08.08.11 22:33, schrieb Ryan Schmidt:
On Aug 7, 2011, at 17:50,[email protected]  wrote:

Revision: 82093
          http://trac.macports.org/changeset/82093
Author:[email protected]
Date:     2011-08-07 15:50:11 -0700 (Sun, 07 Aug 2011)
Log Message:
-----------
nodejs, nodejs-devel: actually use the python version declared in  (fixes 
#30617)
You should increase the ports' revisions so users who already have the old port 
installed will be prompted to rebuild (and so that our buildbot rebuilds them 
too).


The python version mentioned in the commit message (which should read: "nodejs, 
nodejs-devel: actually use the python version declared in ${depends_build} (fixes 
#30617)")
Then you should correct the commit message. Type:

svn propedit --revprop -r 82093 svn:log 
https://svn.macosforge.org/repository/macports
Done.
is only used in the build phase. User who already
installed nodejs/nodejs-devel gain no benefit from a rebuild, so I omitted a 
new revision.
Not true. r82093 changes the shebang line of many scripts that end up getting 
installed. So a revision increase is necessary to propagate that change to 
users' machines.
You are right. Although the node binary itself does not need python, I forgot that the waf-framework is not only used to build node, but will also be installed for those who are adventurous to write their own extensions in C/C++ :-) This implies that python is a runtime dependency, not a build time dependency as currently declared in the portfile. Fixed in r82175, which also includes your proposed patch from https://trac.macports.org/ticket/30673.

--
Christoph


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to