On Oct 11, 2011, at 23:04, [email protected] wrote: > Revision: 85245 > http://trac.macports.org/changeset/85245 > Author: [email protected] > Date: 2011-10-11 21:04:02 -0700 (Tue, 11 Oct 2011) > Log Message: > ----------- > Correct Portfile lint warnings.
You also increased the port's revision, which I can't see any reason to have done. The revision is only increased when the files the port installs change. You also removed the modeline, and introduced tab characters into a formerly tabless portfile; we like portfiles to have modelines, and for the whitespace used to be only spaces; the guide mentions both these things. You also removed the blank line after the portsystem line, but the guide and "lint --nitpick" shows that we want there to be a blank line there. > Modified: trunk/dports/erlang/rebar/Portfile > =================================================================== > --- trunk/dports/erlang/rebar/Portfile 2011-10-12 03:52:19 UTC (rev > 85244) > +++ trunk/dports/erlang/rebar/Portfile 2011-10-12 04:04:02 UTC (rev > 85245) > @@ -1,17 +1,16 @@ > -# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; > c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 > -# $Id: > +# $Id$ > > -PortSystem 1.0 > - > -name rebar > +PortSystem 1.0 > +name rebar > # no real version available > -version 0.0.1 > -categories devel > -platforms darwin > +version 0.0.1 > +revision 1 > +categories erlang devel > +platforms darwin > > -maintainers uwe-arzt.de:mail openmaintainer > +maintainers uwe-arzt.de:mail openmaintainer > > -description Rebar is an Erlang build tool that makes it easy to > compile \ > +description Rebar is an Erlang build tool that makes it easy to compile \ > and test Erlang applications, port drivers and releases. > long_description Rebar is a self-contained Erlang script, so it's easy to \ > distribute or even embed directly in a project. Where > possible, \ _______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
