On Tue, Oct 18, 2011 at 09:10:41PM -0500, Ryan Schmidt wrote:
> On Oct 18, 2011, at 19:07, [email protected] wrote:
> > +# declare universal variant, so get_canonical_archflags works
> > +variant universal       {}
> But you don't ever use [get_canonical_archflags] anywhere.

Copied that from a different Portfile but in the end didn't have to use
it. Fixed now.

> > +configure.env-append    LIBUSB_CFLAGS=-I${prefix}
> 
> That's strange... -I is for specifying paths to include files, and
> there shouldn't be any include files directly in ${prefix}. They
> should be in ${prefix}/include. And MacPorts already puts
> -I${prefix}/include in the CPPFLAGS for you.

That was pulled from a short guide mentioned upstream, but apparently
works just fine without, too. Removed in r86149.

-- 
Clemens Lang
GSoC Student

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to