On 3/5/12 19:23 , Ryan Schmidt wrote:

On Mar 5, 2012, at 03:56, easie...@macports.org wrote:

Revision: 90432
          http://trac.macports.org/changeset/90432
Author:   easie...@macports.org
Date:     2012-03-05 01:56:10 -0800 (Mon, 05 Mar 2012)
Log Message:
-----------
lang/sbcl:  Add variant to force use of llvm-gcc-4.2.


This was in response to [ticket #33446][1] for users who have XCode 4.2 installed. I suppose there is a better way to do this other than variant. Could you please point me to documentation and/or a currently canonical example of determining which version of XCode is being used?

[1]: https://trac.macports.org/ticket/33446#comment:7

[…]


You've combined the $Id$ and modeline lines. The modeline should be the first 
line, and the $Id$ line should be the second line.


-long_description {

[…]


This still contains hard linebreaks. Every other port simply uses backslashes 
at the end of the line of the long_description, thus allowing MacPorts to 
insert soft linebreaks where appropriate for the terminal window's width -- 
just as the sbcl port did before you started making changes. :) It was really 
better the way it was before.

[…]

Both of these remaining metadata convention violations should be resolved in [r90463][2].

[2]: https://trac.macports.org/changeset/90463


If you have whitespace changes to make, they should be made in a separate 
commit.

Alright. I'll try to avoid the temptation to tweak between functional commits…

[…]

+variant use-llvm-gcc-4.2 description {Force the use of LLVM GCC 4.2.
+This is perhaps better handled with the gcc_select port.} {
+    configure.compiler llvm-gcc-4.2
+}

The gcc_select port is for the user's convenience in selecting a compiler for 
their use for things outside of MacPorts; ports themselves may not use the 
compiler the user has selected; ports use the default compiler for the 
currently-installed version of Xcode (which MacPorts sets the 
configure.compiler variable to), or a different compiler the port maintainer 
chose (by setting configure.compiler) if that's necessary for some reason.

Alright. Confusion cleared up for me, although I think this is the second time you have pointed this out. I guess I don't do enough daily work with Macport maintenance to have had this stick. Hopefully I can keep it straight in the future.

[…]

Thanks for your patient mentoring here,
Mark


--
"A screaming comes across the sky.  It has happened before, but there
is nothing to compare to it now."
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to