On Mar 29, 2012, at 08:50, Quentin Smith wrote: > On Thu, 29 Mar 2012, Ryan Schmidt wrote: > >> >> On Mar 29, 2012, at 01:36, [email protected] wrote: >> >>> Revision: 91311 >>> https://trac.macports.org/changeset/91311 >>> Author: [email protected] >>> Date: 2012-03-28 23:36:37 -0700 (Wed, 28 Mar 2012) >>> Log Message: >>> ----------- >>> mosh: maintainer update to v1.1.2; add Leopard support (#33810) >>> >>> Modified Paths: >>> -------------- >>> trunk/dports/net/mosh/Portfile >>> >>> +platform darwin 9 { >>> + depends_build-append port:poll-emulator >>> + configure.args-append poll_CFLAGS="-I${prefix}" poll_LIBS="-L${prefix} >>> -lpoll" >>> +} >> >> I am surprised by these -I and -L arguments. There aren't any headers or >> libraries directly in ${prefix}. Typically we see arguments like >> -I${prefix}/include and -L${prefix}/lib; in fact, MacPorts already sets >> these in ${configure.cppflags} and ${configure.ldflags}, respectively. > > Ahh, it is indeed a typo. Your explanation makes perfect sense. Indeed, mosh > builds fine without the configure.args-append line. (I first tested with a > hard-coded include and library path, and then was overzealous in replacing > them with ${prefix}) > > Feel free to remove that line, or I could create a ticket with a patch if you > prefer.
If you don't think the -lpoll part of that line was needed, I'm happy to remove the line. I'll give it a quick test without that line on a Leopard machine. _______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
