On Mar 31, 2012, at 11:17, [email protected] wrote:
> Revision: 91391
> https://trac.macports.org/changeset/91391
> Author: [email protected]
> Date: 2012-03-31 09:17:06 -0700 (Sat, 31 Mar 2012)
> Log Message:
> -----------
> Correct #32112.
Please be descriptive in your commit message about what the revision does.
Having to refer back to a ticket is inconvenient. Also mention the port name. A
good commit message might be:
qgis: add postgresql90 and postgresql91 variants (#32112)
You can retroactively improve your commit message by using:
svn propedit --revprop svn:log -r 91391
> Modified Paths:
> --------------
> trunk/dports/gis/qgis/Portfile
>
> Modified: trunk/dports/gis/qgis/Portfile
> ===================================================================
> --- trunk/dports/gis/qgis/Portfile 2012-03-31 15:54:39 UTC (rev 91390)
> +++ trunk/dports/gis/qgis/Portfile 2012-03-31 16:17:06 UTC (rev 91391)
> @@ -98,16 +98,21 @@
>
> }
>
> +variant postgresql90 description "Use postgresql 9.0" {
> + depends_lib-append port:postgresql90
> + set PGSQL_DIR ${prefix}/lib/postgresql90
> + configure.args-append "-DPOSTGRES_CONFIG=${PGSQL_DIR}/bin/pg_config"
> +}
> +
> +variant postgresql91 description "Use postgresql 9.1" {
> + depends_lib-append port:postgresql91
> + set PGSQL_DIR ${prefix}/lib/postgresql91
> + configure.args-append "-DPOSTGRES_CONFIG=${PGSQL_DIR}/bin/pg_config"
> +}
These variants should be marked as conflicting with one another.
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
