On Apr 2, 2012, at 03:01, [email protected] wrote:

> Revision: 91451
>          https://trac.macports.org/changeset/91451
> Author:   [email protected]
> Date:     2012-04-02 01:01:06 -0700 (Mon, 02 Apr 2012)
> Log Message:
> -----------
> lang/ccl: update to ccl-1.8 from SVN.
> 
> Modified Paths:
> --------------
>    trunk/dports/lang/ccl/Portfile
> 
> Modified: trunk/dports/lang/ccl/Portfile
> ===================================================================
> --- trunk/dports/lang/ccl/Portfile    2012-04-02 07:42:25 UTC (rev 91450)
> +++ trunk/dports/lang/ccl/Portfile    2012-04-02 08:01:06 UTC (rev 91451)
> @@ -1,3 +1,4 @@
> +# -*- mode: tcl; coding: utf-8; tab-width: 4; indent-tabs-mode: nil; 
> c-basic-offset: 4 -*- # vim:fenc=utf-8:filetype=tcl:et:sw=4:ts=4:sts=4
> # $Id$

You also added the standard modeline. While we do want ports to have the 
standard modeline, we also want ports to conform to what the modeline says: for 
example, that indentations are done at multiples of 4 spaces. The ccl portfile 
currently does not conform to that; in fact its whitespace is very inconsistent 
which makes the portfile hard to read. You should fix the port's whitespace to 
be consistent and to conform with the modeline.


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to