On Apr 18, 2012, at 12:17 PM, Ryan Schmidt wrote: > > On Apr 18, 2012, at 10:47, [email protected] wrote: > >> Revision: 92093 >> https://trac.macports.org/changeset/92093 >> Author: [email protected] >> Date: 2012-04-18 08:47:26 -0700 (Wed, 18 Apr 2012) >> Log Message: >> ----------- >> devel/tao: >> - New port for ACE+TAO. > > This resolves https://trac.macports.org/ticket/33339 yes?
Yes.
>> Added: trunk/dports/devel/tao/Portfile
>
>
>> +set libenv "DYLD_LIBRARY_PATH=${worksrcpath}/lib"
>> +set aceenv "ACE_ROOT=${worksrcpath}"
>> +set taoenv "TAO_ROOT=${worksrcpath}/TAO"
>> +set makearg "INSTALL_PREFIX=${prefix}"
>
> There's no need to quote these.
Is this true if worksrcpath or prefix has spaces?
>> +use_configure no
>
> Since you're not using the configure phase...
>
>> +configure.cmd "\$ACE_ROOT/bin/mpc.pl"
>> +configure.args -type gnuace TAO_ACE.mwc
>> +configure.universal_args
>
> ...and don't reference these variables anywhere else in the portfile, setting
> them serves no purpose and these lines can be removed.
>
>
>> +post-configure {}
>
> Since this block is empty, it serves no purpose and can be removed.
Fixing, thanks.
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ macports-dev mailing list [email protected] http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev
