On May 19, 2012, at 05:37, [email protected] wrote:

> Revision: 93299
>          https://trac.macports.org/changeset/93299
> Author:   [email protected]
> Date:     2012-05-19 03:37:11 -0700 (Sat, 19 May 2012)
> Log Message:
> -----------
> Bump to revision .74. Add gcc47, clang and macports-clang as possible 
> compilers.
> Also removes all manual dylib generation since this is done by Atlas now.
> 
> Modified Paths:
> --------------
>    trunk/dports/math/atlas/Portfile


> -PortSystem                   1.0
> -PortGroup                    muniversal 1.0
> +PortSystem                      1.0
> +PortGroup                       muniversal 1.0
> 
> -categories                   math
> -license                              BSD
> -name                         atlas
> -version                              3.9.47
> +categories                      math
> +license                         BSD
> +name                            atlas
> +version                         3.9.74

Making whitespace changes along with functional changes makes it really hard to 
spot the functional changes. Please make whitespace-only changes in a separate 
commit in the future.


> +variant mpclang                 conflicts gcc45 gcc46 gcc47 clang\
> +                                description {build using MPclang and 
> gfortran} { 
> +    
> +    depends_build-append        port:clang
> +}

The clang port is replaced by the clang-2.9 port, since December already; you 
may not declare a dependency on a port that has been replaced. Instead, offer a 
clang2.9 and/or clang3.0 variant. The first final version of clang 3.1 was 
scheduled to be released May 14, so you might offer a clang3.1 variant too.


> +# Select proper gcc version (or clang)
> +
> +if {${os.major} < 11} {
> +
> +    # On SL or earlier, clang did not exist
> +    if {[variant_isset clang] || [variant_isset dragonegg46]} {
> +    
> +        return -code error "Use of Clang is disabled on this version of 
> MacOS."
> +    }

That's not true; Snow Leopard's Xcode 3 includes a version of clang. Granted 
it's an old version and you may not want to use it:

$ /usr/bin/clang -v
Apple clang version 1.7 (tags/Apple/clang-77) (based on LLVM 2.9svn)
Target: x86_64-apple-darwin10
Thread model: posix

But note that Xcode 4.0 thru 4.2 are available to paid members of Apple's 
developer program on Snow Leopard, and that these of course have much newer 
versions of clang. So your determination of whether to allow the use of Xcode's 
clang should be based on ${xcodeversion}, not ${os.major}.


_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to