On Jun 13, 2012, at 08:30, [email protected] wrote:

> Revision: 94252
>          https://trac.macports.org/changeset/94252
> Author:   [email protected]
> Date:     2012-06-13 06:30:05 -0700 (Wed, 13 Jun 2012)
> Log Message:
> -----------
> pficommon: remove --disable-mysql and --disable-postgresql from 
> configure.args to fix default build.

This does not seem like a good change because the variants now only add 
dependencies, and that's not going to ensure that the port won't use those 
dependencies if the variant is not selected if the dependencies are already 
installed.

When you say "default build", do you mean the build with no variants selected? 
What problem were you encountering that this change fixes?


> Modified Paths:
> --------------
>    trunk/dports/devel/pficommon/Portfile
> 
> Modified: trunk/dports/devel/pficommon/Portfile
> ===================================================================
> --- trunk/dports/devel/pficommon/Portfile     2012-06-13 11:16:11 UTC (rev 
> 94251)
> +++ trunk/dports/devel/pficommon/Portfile     2012-06-13 13:30:05 UTC (rev 
> 94252)
> @@ -34,9 +34,7 @@
> 
> configure.cmd       ./waf configure
> configure.universal_args
> -configure.args-append     --disable-mysql \
> -                          --disable-postgresql \
> -                          --disable-mprpc \
> +configure.args-append     --disable-mprpc \
>                           --disable-fcgi \
>                           --disable-magickpp 
> 
> @@ -44,26 +42,22 @@
> 
> variant mysql5 description {Enable MySQL 5} {
>     depends_lib-append    port:mysql5
> -    configure.args-delete --disable-mysql
> }
> 
> variant postgresql requires postgresql91 description {Obsolete compatibility 
> variant} {}
> 
> variant postgresql91 conflicts postgresql90 postgresql84 description {Enable 
> PostgreSQL 9.1} {
>     depends_lib-append    port:postgresql91
> -    configure.args-delete --disable-postgresql
> }
> 
> variant postgresql90 conflicts postgresql91 postgresql84 description {Enable 
> PostgreSQL 9.0} {
>     depends_lib-append    port:postgresql90
>     set pg_version        90
> -    configure.args-delete --disable-postgresql
> }
> 
> variant postgresql84 conflicts postgresql91 postgresql90 description {Enable 
> PostgreSQL 8.4} {
>     depends_lib-append    port:postgresql84
>     set pg_version        84
> -    configure.args-delete --disable-postgresql
> }

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev

Reply via email to