On 10.7.2012, at 19.01, Mojca Miklavec wrote:

> On Tue, Jul 10, 2012 at 7:52 AM, Ryan Schmidt wrote:
>> On Jul 8, 2012, at 08:48, [email protected] wrote:
>> 
>>> Revision: 95281
>>>         https://trac.macports.org/changeset/95281
>>> Author:   [email protected]
>>> Date:     2012-07-08 06:48:54 -0700 (Sun, 08 Jul 2012)
>>> Log Message:
>>> -----------
>>> as this is a -devel port, version bump to rc1 of 2.9.4, the proper release 
>>> coming in the near future, modernise checksums, modify the patch file to 
>>> enable universal build
>> 
>> Since this is 2.9.4-rc1, the version field should read "2.9.4-rc1", not 
>> "2.9.4", and the master_sites should be changed back to what they were 
>> before.
> 
> The version rc1 doesn't even exist on servers any more. It should be
> changed back to 2.9.4.

Thanks, so it seems we do this before the new release is announced!
> 
> I also believe that compiler could be changed back to default (clang
> instead of llvm-gcc-4.2), both in wxWidgets-devel as well as in all
> other ports depending on it.

Yes, I noticed that the configure variable settings confuse the builds, just 
dropping the conditional compiler setting left llvm hanging around somewhere 
leading to failure in preprocessor sanity check (see below). I'm just running a 
test build with release version, clang (it works already with rc1), and the 
changes below. So far seems to be ok!
> 
> Plus, I believe/recall from my memory that the following could go away
> (but I didn't test it yet):
> 
> platform darwin 11 {
>    # 'InsetRect' was not declared in this scope
>    macosx_deployment_target 10.6
> }
> 
> and one also needs something like
> 
> if {${os.major} < 9} {
>    pre-fetch {
>        ui_error "${name} requires Mac OS X 10.5 or later."
>        return -code error "incompatible Mac OS X version"
>    }
> }
> 
> to make it explicit that 2.9.4 doesn't work on Tiger.
> 
> I also remember having problems with configure.CPP, but I cannot
> recall what it was exactly (I commented it out in attachment, but I'm
> not sure about that change).
> 
> The port builds for a very very long time, which is why I cannot test
> as fast as I would like to.

Same here:)
> 
> Mojca
> 
> PS: I'm attaching *untested* Portfile with the changes I mention above
> + some (incomplete) whitespace modifications. I don't dare creating a
> ticket yet since I know that all those changes (whitespace in
> particular) should be separated from the rest, and I would need to
> test on different OSes first. I only attached the Portfile to better
> explain what I had in mind in what I wrote above.
> <wxWidgets-devel.Portfile>

_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to