>
>> +PortGroup kde4 1.1
>
>> +if {![variant_isset doc]} {
>> + patchfiles-append patch-CMakeLists.txt.diff
>> +}
>
> The variant defined by the kde4-1.1 portgroup is called docs, not doc.
I thought all ports were ok about this typo which was around for some time, but
obviously not, as I took this from copy paste. I checked all kde ports and
hope to have corrected all of them in r99720.
>> Added: trunk/dports/kde/ffmpegthumbs/Portfile
>
>> +depends_lib-append port:kdelibs4 \
>> + port:ffmpeg
>
> Dependencies on ffmpeg should be written such that ffmpeg-devel could satisfy
> them. See existing ports that depend on ffmpeg.
Sorry, I was not aware of that. Corrected in r99721.
>> Modified: trunk/dports/kde/kdemultimedia4/Portfile
>
>> +depends_lib-append port:dragon \
>> + port:ffmpegthumbs \
>> + port:juk \
>> + port:kmix \
>> + port:kscd \
>> + port:libkcompactdisc \
>> + port:libkcddb \
>> + port:mplayerthumbs
>> +# port:audiocd-kio
>
>> +destroot {
>> + # Create a dummy file so the port can be successfully activated
>> + xinstall -d ${destroot}${prefix}/share/doc/kdemultimedia4
>> + set docfile [open
>> ${destroot}${prefix}/share/doc/kdemultimedia4/README.${name}.txt "w"]
>> + puts $docfile "Meta-port for kdemultimedia4\n"
>> + puts $docfile "${long_description}\n"
>> + close $docfile
>> +}
>
> Is it the case that the kdemultimedia4 port used to provide the files that
> are now provided by these individual ports? If so, then those individual
> ports must employ the "deactivate hack" to avoid activation errors when
> upgrading. See also #36992 which is a similar issue about kde4-runtime.
True, I overlooked that. I will test to see which ports require the hack.
Thanks for spotting these point.
Cheers,
Nicolas
_______________________________________________
macports-dev mailing list
[email protected]
http://lists.macosforge.org/mailman/listinfo/macports-dev
