On Mar 10, 2013, at 15:13, [email protected] wrote:
> Revision: 103948
> https://trac.macports.org/changeset/103948
> Author: [email protected]
> Date: 2013-03-10 13:13:30 -0700 (Sun, 10 Mar 2013)
> Log Message:
> -----------
> sudo: update to 1.8.6p7, convert setup message to notes, unify whitespace,
> closes #38351
Ideally whitespace changes should be made in a separate commit so they can be
ignored and functional changes can be more easily seen.
> -post-install {
> - ui_msg "------------------------------------------------------------"
> - ui_msg "To complete installation run:"
> - ui_msg " ${prefix}/bin/sudo ${prefix}/sbin/visudo"
> - ui_msg "Edit as necessary (see the"
> - ui_msg "sudoers manpage for additional information)."
> - ui_msg "------------------------------------------------------------"
> -}
> +notes "\
> +------------------------------------------------------------\n\
> +To complete installation run:\n\
> +\t${prefix}/bin/sudo ${prefix}/sbin/visudo\n\
> +Edit as necessary (see the sudoers manpage for additional\n\
> +information).\n\
> +------------------------------------------------------------"
Notes shouldn't introduce manual line breaks in the middles of sentences; when
displayed, MacPorts inserts line breaks into the notes automatically for you
where appropriate for the current width of the terminal window.
Decorations like "--------" shouldn't be used to frame notes; it gives the
impression that the author feels this port's notes are more important than
other ports' notes, which I don't think we want to convey. Just let the notes
be the text that you want displayed, and let MacPorts handle the details of how
they're displayed. If it is thought that notes are not displayed prominently
enough, then let that problem be solved globally at the MacPorts base level
rather than individually for each port.
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
