On May 11, 2013, at 01:21, Lawrence Velázquez <[email protected]> wrote:

> On May 11, 2013, at 1:51 AM, Ryan Schmidt <[email protected]> wrote:
> 
>> What's the idea behind manually setting master_sites, distname and 
>> worksrcdir? The github portgroup is supposed to handle this for you. The 
>> choices for where to download from github are supposed to be from tags (the 
>> default) or downloads (but the downloads feature of github is deprecated so 
>> this is probably going away eventually).
> 
> The URL on the GitHub tags page 
> (https://github.com/technomancy/leiningen/tags) is 
> "https://github.com/technomancy/leiningen/archive/2.1.3.tar.gz";, so I thought 
> I had to fudge the portfile to make the fetch work. Didn't think the 
> portgroup's "/tarball" URL would redirect.
> 
> Detritus removed in r105957.

The good people at github did some sort of reorganization which changed the 
advertised URLs, but the old ones still redirect. I wasn't sure if we needed to 
change the portgroup. The problem is that if we do, the distfile names change, 
so it might have to be a setting in the portgroup that individual ports can opt 
into. (If we go this way, we should make the option something like 
"github.legacy_tarball", make it default to no, edit each port using the 
portgroup to set it to yes, and then as each port is updated, that setting 
would be removed.)

_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to