On May 12, 2013, at 14:42, [email protected] wrote:
> Revision: 105993
> https://trac.macports.org/changeset/105993
> Author: [email protected]
> Date: 2013-05-12 12:42:50 -0700 (Sun, 12 May 2013)
> Log Message:
> -----------
> abtransfers: new port
Some notes on this port below.
> Added: trunk/dports/finance/abtransfers/Portfile
> +# See dports/_resources/port1.0/group/qt4-1.0.tcl for more info.
> +PortGroup qt4 1.0
This comment is fine if it helps you, but it's the same for every portgroup:
for any X, Y, and Z, the file for "PortGroup X Y.Z" is the file
dports/_resources/port1.0/group/X-Y.Z.tcl. We don't usually add comments to
portfiles that explain basic MacPorts features; it would quickly become
redundant.
> +name abtransfers
> +distname abtransfers-${version}
${name}-${version} is the default distname.
> +configure {
> + system "cd ${worksrcpath}; qmake \"INCLUDEPATH +=
> ${prefix}/include/aqbanking5 ${prefix}/include/gwenhywfar4\""
> +}
Should instead use 'system -W ${worksrcpath} "qmake …"'.
> +destroot {
> + xinstall -m 0755 -d ${destroot}${applications_dir}
No need to manually create directories that are part of the standard mtree;
MacPorts creates them for you prior to destroot.
> + file copy ${worksrcpath}/build/${name}.app
> ${destroot}${applications_dir}
> +}
This is fine, but you can also shorten the standard Tcl "file copy" to the
MacPorts-specific synonym "copy". (It's almost silly that we have this synonym,
but we do.)
> +patch.pre_args -p0
> +patchfiles patch-main.cpp.diff
-p0 is the default patch.pre_args.
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
