On Aug 6, 2013, at 03:02, [email protected] wrote:
> Revision: 109001
> https://trac.macports.org/changeset/109001
> Author: [email protected]
> Date: 2013-08-06 01:02:58 -0700 (Tue, 06 Aug 2013)
> Log Message:
> -----------
> port freerdp: reenabling X11 client; fix #40020
>
> Modified Paths:
> --------------
> trunk/dports/net/FreeRDP/Portfile
>
> Modified: trunk/dports/net/FreeRDP/Portfile
> ===================================================================
> --- trunk/dports/net/FreeRDP/Portfile 2013-08-06 04:56:55 UTC (rev 109000)
> +++ trunk/dports/net/FreeRDP/Portfile 2013-08-06 08:02:58 UTC (rev 109001)
> @@ -18,6 +18,8 @@
>
> checksums rmd160 0a08ae4452603d89a7596be2f6825f2f33fe2c9c \
> sha256
> ead34bb077451190abc177c5fda036b74191dba02045d69b59d0b9f29e9a1b38
> +
> +depends_lib-append path:lib/libavcodec.dylib:ffmpeg-devel
> +depends_build-append port:xorg-libX11
>
> -depends_lib path:lib/libavcodec.dylib:ffmpeg-devel
> -
> +configure.args-append "-DWITH_X11=ON"
Since this changes the files the port installs, the revision needs to be
increased.
I'll bet it links with libraries provided by xorg-libX11, so that should be in
depends_lib not depends_build. Actually, I don't need to bet; I can prove it:
$ otool -L /opt/local/bin/xfreerdp
/opt/local/bin/xfreerdp:
/opt/local/lib/libXinerama.1.dylib (compatibility version 2.0.0,
current version 2.0.0)
/opt/local/lib/libXext.6.dylib (compatibility version 11.0.0, current
version 11.0.0)
/opt/local/lib/libXcursor.1.dylib (compatibility version 2.0.0, current
version 2.2.0)
/opt/local/lib/libXv.1.dylib (compatibility version 2.0.0, current
version 2.0.0)
/opt/local/lib/libXi.6.dylib (compatibility version 8.0.0, current
version 8.0.0)
/opt/local/lib/libXrender.1.dylib (compatibility version 5.0.0, current
version 5.0.0)
/opt/local/lib/libX11.6.dylib (compatibility version 10.0.0, current
version 10.0.0)
/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current
version 1.2.8)
/opt/local/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current
version 1.0.0)
/opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0,
current version 1.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
version 169.3.0)
/usr/lib/libgcc_s.1.dylib (compatibility version 1.0.0, current version
1669.0.0)
Given the above list of libraries linked to, perhaps some other dependencies
need to be added also?
There's no reason to quote the configure arg, by the way.
While you're editing the port, the description could be adjusted. There's no
need to mention the license there, since there's a separate license field. And
I'm not sure what the sentence "Currently on Xorg client is working" is saying;
I think there's a typo but I'm not sure what it is. (Was "on" supposed to be
"no"? If so, this revision seems to contradict that.)
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
