On Jun 14, 2014, at 11:01 AM, Frank Schima <[email protected]> wrote:
> Hi Mark, > > > Some observations about this Portfile: > > On Jun 14, 2014, at 9:49 AM, Mark Brethen <[email protected]> wrote: > >> This is what I have in the Portfile so far: >> >> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; >> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 >> # $Id$ >> >> PortSystem 1.0 >> >> PortGroup github 1.0 >> github.setup tpaviot oce 0.15 OCE- >> >> categories graphics >> maintainers gmail.com:mark.brethen >> description Open CASCADE Community Edition >> Long_description OCE is a fork for patches/improvements/experiments\ >> over OpenCascade. > > Please determine and add the correct license. This will allow Macports to > distribute a binary - license permitting. > >> >> homepage https://github.com/tpaviot/oce >> >> checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \ >> sha256 >> 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1 >> >> depends_build port:cmake \ >> port:ftgl \ >> port:freeimage \ >> port:gl2ps \ >> Port:tbb > > Since you are using a portgroup - github in this case - it might have > dependencies. But you are overriding them by setting depends_build. Instead > you should use depends_build-append. > >> configure { >> system "cd ${worksrcpath} && cmake ${configure.args} ${worksrcpath};” >> } > > A couple of issues here. You should consider adding the cmake portgroup which > is designed for ports that build with cmake. That will likely make this > entire block unnecessary. Also, please do not use system “cd….”. Per the > guide [1], you should use the -W flag instead. I.e. > > system -W ${worksrcpath} “cmake ..." > > > Cheers! > Frank > > [1] <https://trac.macports.org/wiki/FAQ#cd> > > _______________________________________________ > macports-dev mailing list > [email protected] > https://lists.macosforge.org/mailman/listinfo/macports-dev Revised Portfile based on comments from the group: # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 # $Id$ PortSystem 1.0 PortGroup cmake 1.0 PortGroup github 1.0 github.setup tpaviot oce 0.15 OCE- categories graphics maintainers gmail.com:mark.brethen description Open CASCADE Community Edition Long_description OCE is a fork for patches/improvements/experiments\ over OpenCascade. license LGPL 2.1 homepage https://github.com/tpaviot/oce checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \ sha256 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1 depends_build-append port:cmake \ port:ftgl \ port:freeimage \ port:gl2ps \ Port:tbb configure.args-append \ -DOCE_DRAW:BOOL=ON" \ -DOCE_WITH_FREEIMAGE:BOOL=ON \ -DOCE_WITH_GL2PS:BOOL=ON \ -DOCE_MULTITHREAD_LIBRARY:STRING=TBB Again, I'm following build notes for Mac OS X at: https://github.com/tpaviot/oce/wiki/Build-%28Mac-OSX%29 . Thanks, Mark _______________________________________________ macports-dev mailing list [email protected] https://lists.macosforge.org/mailman/listinfo/macports-dev
