On 6/22/14, 6:55 PM, Ryan Schmidt wrote:
On Jun 22, 2014, at 9:54 AM, Kurt Hindenburg wrote:
On 6/21/14, 7:20 PM, Ryan Schmidt wrote:
Wouldn't this patch be safe to use on all OS X versions? If so, that should be
done. This will ensure that someone updating the port on a version of OS X
earlier than Mavericks does not inadvertently forget to update the patch, if
needed.
I don't think so as the ticket was only for building on Mavericks. Also, the
buildbots didn't throw up any errors. The only way I could test is to add it
to all versions and see what the buildbot did.
Kurt
I know the ticket was about a build failure only on Mavericks. The reason for
the build failure was that daemon includes an unconditional definition of the
function strlcat, but Mavericks now includes its own version of it, thus
causing a conflict. The patch that you added fixes the problem by only defining
strlcat if it is not already defined. Thus it seems like it should be safe to
use that patch on all versions of OS X, which would be preferred for the
above-stated reason.
Ok, thanks for the explanation - I've committed to use the patch on all
versions.
Kurt
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
