On Aug 9, 2014, at 8:31 PM, Joshua Root <[email protected]> wrote: > > On 2014-8-10 04:07 , Lawrence Velázquez wrote: >> On Aug 9, 2014, at 11:47 AM, Frank Schima <[email protected]> wrote: >> >>> Just curious about why you are removing the indenting spacing in these perl >>> ports? I would say it is more common to indent in blocks. I’m open to a >>> discussion about what is preferred. I know when I edit p5 and other ports, >>> I add 4 spaces as indent for all blocks. It makes things much more clear in >>> my mind. I don’t want to get into the situation where people are >>> accidentally reversing each other’s edits! :) I think a consensus would be >>> a good idea here. >> >> Many Perl ports don't indent the 'if {${perl5.major} != ""}' block. I've >> always assumed that it's because that block often contains a significant >> portion of the ports' logic, and most of the content would end up being >> indented. I find it rather ugly. > > I think I may have scripted the bulk addition of those if statements at > one point, and not bothered trying to indent them properly.
And I assumed Mojca was trying to go back to that old style in preparation for a future removal of those if statements and going back to a single version of perl, as has been recently discussed but IIRC not yet decided upon. For now I am just adding all perl versions to ports as I get to them, so that we can address any perl5.18- or perl5.20-specific issues as they come up, and get closer to a time when all ports are shown to work with perl5.20. _______________________________________________ macports-dev mailing list [email protected] https://lists.macosforge.org/mailman/listinfo/macports-dev
