> On Jan 10, 2015, at 18:51, Ryan Schmidt <[email protected]> wrote: > > >> On Jan 10, 2015, at 2:53 PM, [email protected] wrote: >> >> Revision >> 131393 >> Author >> [email protected] >> Date >> 2015-01-10 12:53:49 -0800 (Sat, 10 Jan 2015) >> Log Message >> >> clang-3.5: Build fix for Leopard > >> Modified: trunk/dports/lang/llvm-3.5/Portfile (131392 => 131393) > >> - if {${subport} eq "clang-${llvm_version}" && ${os.major} <= 9} { >> - patchfiles-append 0001-Leopard-Default-to-fno-blocks.patch >> + if {${subport} == "clang-${llvm_version}" && ${os.major} <= 9} { >> + patchfiles-append leopard-no-asan.patch >> 0001-Leopard-Default-to-fno-blocks.patch > > FYI string comparisons should be done with eq and ne, not == and !=. It's not > really a big deal, it's just that Larry just fixed this in r129354 and now > you've undone it.
Yeah, it got reverted in a copy/paste from llvm-3.3, which Larry didn't fix yet. I noticed it afterwards and thought it was cleaned up before submission, but apparently I only fixed it in 3.6 and not 3.5. I've re-rixed it. --Jeremy _______________________________________________ macports-dev mailing list [email protected] https://lists.macosforge.org/mailman/listinfo/macports-dev
