On 4/7/15 7:22 PM, [email protected] wrote:
[134818] trunk/dports/graphics/lib2geom/Portfile
Revision
134818 <https://trac.macports.org/changeset/134818>
Author
[email protected]
Date
2015-04-07 19:22:17 -0700 (Tue, 07 Apr 2015)
Log Message
lib2geom: use system's -W argument instead of running "cd"; use ${worksrcpath};
use expand operator instead of eval
Modified Paths
* trunk/dports/graphics/lib2geom/Portfile
<#trunkdportsgraphicslib2geomPortfile>
Diff
Modified: trunk/dports/graphics/lib2geom/Portfile (134817 =>
134818)
post-destroot { xinstall -d
${destroot}${prefix}/share/doc/${name}/html - eval xinstall -m 644
[glob ${workpath}/${name}-${version}/doc/html/*] \ + xinstall -m 644
{*}[glob ${worksrcpath}/doc/html/*] \
${destroot}${prefix}/share/doc/${name}/html } }
Ryan --
Thanks for these enhancements, particularly the use of the "expand
operator", introduced in Tcl 8.5, in preference to the now deprecated
'eval'. [1]
I note, however, that the use of 'eval' is fairly wide spread throughout
the ports, PortGroups and base as well as the usage examples provided
for the 'xinstall' command in the Guide.
If the goal is to use Tcl 8.5 preferred syntax throughout (a good idea
IMO), then it might be prudent to make a more explicit announcement of
that policy, including updating the Guide, so that all maintainers are
aware of the issue.
Dave
[1] http://wiki.tcl.tk/17158
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
