> On Jul 17, 2015, at 11:30 PM, [email protected] wrote:
> 
> Revision
> 138753
> Author
> [email protected]
> Date
> 2015-07-17 21:30:09 -0700 (Fri, 17 Jul 2015)
> Log Message
> 
> extractopinion: use perl5.22; see #48365
> Modified Paths
> 
>       • trunk/dports/textproc/extractopinion/Portfile
> Diff
> 
> Modified: trunk/dports/textproc/extractopinion/Portfile (138752 => 138753)
> 
> --- trunk/dports/textproc/extractopinion/Portfile     2015-07-18 04:28:26 UTC 
> (rev 138752)
> +++ trunk/dports/textproc/extractopinion/Portfile     2015-07-18 04:30:09 UTC 
> (rev 138753)
> @@ -29,7 +29,7 @@
>  depends_lib         port:crfpp \
>                      port:libiconv \
>                      port:gawk \
> -                    port:p5.16-text-csv_xs \
> +                    port:p5.22-text-csv_xs \
>                      port:juman6 \
>                      port:knp3

This change looks incomplete. How does the port know to use the files installed 
by p5.22-text-csv_xs instead of those installed by p5.16-text-csv_xz?

In fact, it looks like the determination of which perl version to use is 
hardcoded into the file patch-perl.diff -- and it says to use perl5.12. This 
needs to be updated. Perhaps the mechanism can also be improved so future 
updates are more straightforward and the opportunity to forget to update the 
perl version in all places is eliminated.

_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to