On 2016-09-16 17:33, Ryan Schmidt wrote:
> 
>> On Sep 16, 2016, at 9:06 AM, Rainer Müller <rai...@macports.org> wrote:
>>
>> I would keep this as Mac OS X 10.5 Leopard, the name does not change
>> retroactively.
> 
> I suppose that's an open question. Previously, I've tried to use the OS 
> marketing name as it was when that OS version was released. Now, I'm thinking 
> we should always use the current marketing name. Do we have any guidance from 
> Apple on what they want people to do?
> 
>> The version number is usually also helpful to get the
>> "10.X" to "darwin Y" mapping right.
> 
> Yes but I didn't want to go into a long explanation in that comment.

Then let's just replace it here with "(e.g. 16 for macOS 10.12 Sierra)"
to avoid the confusion.

>>> options minimum_xcodeversions
>>> @@ -57,7 +57,7 @@
>>>                     return -code error "unable to find Xcode"
>>>                 }
>>>                 if {[vercmp ${xcodeversion} ${minimum_xcodeversion}] < 0} {
>>> -                    ui_error "On Mac OS X ${macosx_version}, ${name} 
>>> ${version} requires Xcode ${minimum_xcodeversion} or later but you have 
>>> Xcode ${xcodeversion}."
>>> +                    ui_error "On macOS ${macosx_version}, ${name} 
>>> @${version} requires Xcode ${minimum_xcodeversion} or later but you have 
>>> Xcode ${xcodeversion}."
>>
>> Why drop the foo @1.0 syntax that we use at so many other places to
>> specify a port version?
> 
> I didn't drop it; I started using it, finally, in this portgroup.

Sorry, somehow I misread that in reverse... I blame Friday :-)

Rainer
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Reply via email to