> On Oct 24, 2016, at 6:56 AM, Mojca Miklavec <mo...@macports.org> wrote: > > On 20 October 2016 at 10:41, Mojca Miklavec wrote: >> On 20 October 2016 at 04:42, Joshua Root wrote: >>> On 2016-10-20 13:23 , Ryan Schmidt wrote: >>>> >>>> >>>>> On Oct 19, 2016, at 9:04 PM, mo...@macports.org wrote: >>>>> >>>>> Revision >>>>> 154081 >>>>> Author >>>>> mo...@macports.org >>>>> Date >>>>> 2016-10-19 19:04:20 -0700 (Wed, 19 Oct 2016) >>>>> Log Message >>>>> >>>>> extractopinion: switch to perl5.24 (#52081) >>>>> Modified Paths >>>>> >>>>> • trunk/dports/textproc/extractopinion/Portfile >>>> >>>> >>>>> @@ -29,7 +29,7 @@ >>>>> depends_lib port:crfpp \ >>>>> port:libiconv \ >>>>> port:gawk \ >>>>> - port:p5.22-text-csv_xs \ >>>>> + port:p5.24-text-csv_xs \ >>>>> port:juman6 \ >>>>> port:knp3 >>>> >>>> >>>> This only changes the dependency but doesn't tell the build system to use >>>> it. That needs to be done in patch-perl.diff. (We've actually forgotten to >>>> change this every time since perl5.12.) >>> >>> Probably a good reason to use a placeholder string in the patch file and >>> then reinplace it with the actual version-specific string in the portfile. >> >> I agree. But then again this might also be a good reason to ask >> ourselves whether we have any users of this software at all. Not even >> the patch phase succeeds and there were apparently no complaints about >> a broken port for years. (Unless the users gave up too soon and didn't >> know how to file a bug report.) > > I committed a fix in r154202 (https://trac.macports.org/changeset/154202). > > If I missed something, please let me know.
Since r154202 changes the files that get installed, the revision should be increased. _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
