> On Nov 14, 2016, at 7:25 AM, NicosPavlov
> <[email protected]> wrote:
>
> NicosPavlov pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/7b571f2dcc80a4650dfd5f9be8f03a40bb53cad7
>
> The following commit(s) were added to refs/heads/master by this push:
>
> new 7b571f2 msieve: upgrade to 1.53, add ecm variant, take
> maintainership
>
> 7b571f2 is described below
> @@ -32,6 +33,10 @@ post-patch {
>
> use_configure no
>
> +if {[variant_isset ecm]} {
> + build.args ECM=1
> +}
> +
Why did you put this code here in a block by itself? Why not set (or better
yet: append to) build.args inside the emc variant declaration, so that all the
code relating to the variant is in one place?
> build.env CFLAGS="${configure.cflags}" \
> CPATH="${compiler.cpath}" \
> LIBRARY_PATH="${compiler.library_path}" \
> @@ -53,6 +58,10 @@ destroot {
> ${destroot}${prefix}/share/${name}/demo
> }
>
> +variant ecm description "Use elliptic curve method for factorisation" {
> + depends_lib-append port:gmp-ecm
> +}
