> On Jan 13, 2017, at 1:24 AM, Ryan Schmidt <ryandes...@macports.org> wrote:
> 
> 
>> On Jan 11, 2017, at 08:56, Mark Moll <mm...@macports.org> wrote:
>> 
>> Mark Moll (mamoll) pushed a commit to branch master
>> in repository macports-ports.
>> 
>> 
>> https://github.com/macports/macports-ports/commit/ac9a9ab102bc2026808f6a869d6fdbed41434523
>> 
>> commit ac9a9ab102bc2026808f6a869d6fdbed41434523
>> 
>> Author: Mark Moll <mm...@macports.org>
>> AuthorDate: Wed Jan 11 08:56:41 2017 -0600
>> 
>> 
>>    py-graph-tool: add Python 3.6 version
>> 
>> ---
>> python/py-graph-tool/Portfile | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/python/py-graph-tool/Portfile b/python/py-graph-tool/Portfile
>> index 0b7746a..2e45c12 100644
>> --- a/python/py-graph-tool/Portfile
>> +++ b/python/py-graph-tool/Portfile
>> @@ -28,7 +28,7 @@ checksums           md5     
>> 6b68edf0ef5efc375b467a7a117eb9c2 \
>>                     sha256  
>> eba1090f94b0434890beedaf0c100dd0fc77e41ebfe29b4725d76cadb82099af
>> distname            ${realname}-${version}
>> 
>> -python.versions     27 34 35
>> +python.versions     27 34 35 36
>> python.default_version 27
>> 
>> if {${os.major} <= 12 && ${os.platform} eq "darwin"} {
>> @@ -100,6 +100,10 @@ if {${name} ne ${subport}} {
>>     if {${python.version} eq "27"} {
>>         configure.env-append PYTHON_EXTRA_LIBS="-u _PyMac_Error"
>>     }
>> +    # Something similar is happening with python3.6
>> +    if {${python.version} eq "27"} {
>> +        configure.env-append PYTHON_EXTRA_LIBS="-Wl,-stack_size,1000000 
>> -framework CoreFoundation ${python.lib}"
>> +    }
> 
> In addition to adding the python 3.6 version of this module, you appear to 
> have added code that affects the python 2.7 version of this module. I'm 
> unclear whether this was intentional, and whether it will overwrite the 
> previously set value of PYTHON_EXTRA_LIBS. I'm also unclear whether this will 
> result in a change to the installed files or not.

The `eq “27”` part was a typo, and fixed a few minutes later in commit 
b7c745c3462520482f5ae11e645fa5414e40e29f. The hacky fix works around a problem 
in python2.7 and 3.6, which can be seen by observed by running this command for 
different versions of python:

python -c "import distutils.sysconfig; 
print(distutils.sysconfig.get_config_var('LINKFORSHARED'))"


— Mark


Reply via email to