On 2017-1-14 03:02 , Mark Moll wrote:


On Jan 13, 2017, at 1:24 AM, Ryan Schmidt <ryandes...@macports.org> wrote:

@@ -100,6 +100,10 @@ if {${name} ne ${subport}} {
    if {${python.version} eq "27"} {
        configure.env-append PYTHON_EXTRA_LIBS="-u _PyMac_Error"
    }
+    # Something similar is happening with python3.6
+    if {${python.version} eq "27"} {
+        configure.env-append PYTHON_EXTRA_LIBS="-Wl,-stack_size,1000000 -framework 
CoreFoundation ${python.lib}"
+    }

In addition to adding the python 3.6 version of this module, you appear to have 
added code that affects the python 2.7 version of this module. I'm unclear 
whether this was intentional, and whether it will overwrite the previously set 
value of PYTHON_EXTRA_LIBS. I'm also unclear whether this will result in a 
change to the installed files or not.

The `eq “27”` part was a typo, and fixed a few minutes later in commit 
b7c745c3462520482f5ae11e645fa5414e40e29f. The hacky fix works around a problem 
in python2.7 and 3.6, which can be seen by observed by running this command for 
different versions of python:

python -c "import distutils.sysconfig; 
print(distutils.sysconfig.get_config_var('LINKFORSHARED'))"

It's not quite as simple as "a problem in python", but see <https://github.com/macports/macports-ports/pull/53> for the details.

- Josh

Reply via email to