> On Jan 16, 2017, at 10:02, Marcus Calhoun-Lopez <[email protected]> wrote:
>
> MarcusCalhoun-Lopez pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/405fda5122ab2983e7c16636133debb9783fd22b
>
> commit 405fda5122ab2983e7c16636133debb9783fd22b
>
> Author: Marcus Calhoun-Lopez <[email protected]>
> AuthorDate: Mon Jan 16 09:00:19 2017 -0700
>
>
> gimp2-launcher: add new port
>
>
>
> gimp2-launcher is an alternative to gimp-app.
>
> The major difference to end users is the icons.
>
> ---
> aqua/gimp-app/Portfile | 2 +
> aqua/gimp2-launcher/Portfile | 62
> +++++++++++++++++++++++++
> aqua/gimp2-launcher/files/patch-Info.plist.diff | 16 +++++++
> 3 files changed, 80 insertions(+)
>
> +#use_dmg yes
>
> +# use_dmg requires root access
>
> +# unable to reproduce error in portextract.tcl that justifies this
>
> +set dmg_mount [mkdtemp "/tmp/mports.XXXXXXXX"]
>
> +option extract.cmd [findBinary hdiutil ${portutil::autoconf::hdiutil_path}]
>
> +option extract.pre_args attach
>
> +option extract.post_args "-private -readonly -nobrowse -mountpoint
> \\\"${dmg_mount}\\\" && cd \\\"${dmg_mount}\\\" && [findBinary find
> ${portutil::autoconf::find_path}] . -depth -perm -+r -print0 | [findBinary
> cpio ${portutil::autoconf::cpio_path}] -0 -p -d -m -u
> \\\"${extract.dir}/${distname}\\\"; status=\$?; cd / && ${extract.cmd} detach
> \\\"${dmg_mount}\\\" && [findBinary rmdir ${portutil::autoconf::rmdir_path}]
> \\\"${dmg_mount}\\\"; exit \$status"
This doesn't seem like a good reason to duplicate code from base in your
portfile. If there's a base bug, let's fix the base bug.
A ticket we might use is https://trac.macports.org/ticket/21117
> --- /dev/null
>
> +++ b/aqua/gimp2-launcher/files/patch-Info.plist.diff
>
> @@ -0,0 +1,16 @@
>
> +--- GIMP.app/Contents/Info.plist.orig 2016-07-16 12:52:03.000000000
> -0700
>
> ++++ GIMP.app/Contents/Info.plist 2017-01-15 05:57:02.000000000 -0700
>
> +@@ -26,13 +26,6 @@
>
> + <string>2.8.18</string>
This version number may need to be reinplaced with the real version number in
the future.
> + <key>NSHumanReadableCopyright</key>
>
> + <string>© 1995-2016 The GIMP Development Team</string>
>
> +- <key>LSMinimumSystemVersion</key>
>
> +- <string>10.6.0</string>
>
> +- <key>LSMinimumSystemVersionByArchitecture</key>
>
> +- <dict>
>
> +- <key>x86_64</key>
>
> +- <string>10.6.0</string>
>
> +- </dict>
>
> + <key>NSHighResolutionCapable</key>
>
> + <true />
>
> + <key>CFBundleDocumentTypes</key>
>
>
