> On 17 gen 2017, at 19:09, Joshua Root <[email protected]> wrote: > > I guess you're aware that this doesn't actually do anything, and the variants > only exist to encourage the user to specify one when installing?
Yep, that was the intention. > The downsides: > * The situation where the user doesn't specify a variant is contradictory. > pgcli will be installed with +postgresql96 but py-psycopg2 will be installed > with +postgresql95. Similarly when the user already has py-psycopg2 > installed, the variant they specify when installing pgcli will have no actual > effect. > > * Binary distribution now doesn't happen if the user asks for anything but > +postgresql96, even though the installed files are identical. Hmm, those are actually very good points. I think we should remove the variants from pgcli altogether. What do you think, Ivan? -- Aljaž Srebrnič a.k.a g5pw My public key: https://g5pw.me/key Key fingerprint = 2109 8131 60CA 01AF 75EC 01BF E140 E1EE A54E E677
signature.asc
Description: Message signed with OpenPGP using GPGMail
