> On May 7, 2017, at 00:57, Zero King <[email protected]> wrote: > > Zero King (l2dy) pushed a commit to branch weechat-revert-hack > in repository macports-ports. > > > https://github.com/macports/macports-ports/commit/6c12c1c2fd5df60077770693da9887b8e989866a > > commit 6c12c1c2fd5df60077770693da9887b8e989866a > > Author: Zero King <[email protected]> > AuthorDate: Thu May 4 13:53:04 2017 +0000 > > > Revert "port weechat: deleting files previously installed outside > destroot; fixes building in buildbot" > > > > This reverts commit 280622001b76efaab9ed3b5c0bca5b815f26fd9e. > > --- > irc/weechat/Portfile | 12 ------------ > 1 file changed, 12 deletions(-) > > > diff --git a/irc/weechat/Portfile b/irc/weechat/Portfile > > index badbe0c..e872932 100644 > > --- a/irc/weechat/Portfile > > +++ b/irc/weechat/Portfile > > @@ -160,15 +160,3 @@ post-destroot { > > xinstall -m 644 -W ${worksrcpath} AUTHORS.adoc COPYING ChangeLog.adoc > README.adoc ${destroot}${prefix}/share/doc/weechat > xinstall -m 644 -W ${worksrcpath} {*}[glob doc/en/weechat*.adoc] > ${destroot}${prefix}/share/doc/weechat > } > > - > > -post-install { > > - # if present then remove file previously installed outside destroot > > - foreach file {include/weechat/weechat-plugin.h} { > > - set filepath ${prefix}/${file} > > - if {[file exists ${filepath}] && [registry_file_registered > ${filepath}] == "0"} { > > - if {[catch {delete ${filepath}}]} { > > - ui_warn "Cannot delete ${filepath}; please remove it > manually" > > - } > > - } > > - } > > -}
There's nothing special about the buildbot. It's a computer using MacPorts, just like any other. So if this problem affected the buildbot, it would also affect any other user system, so the fix should not be immediately reverted; it should be left in place long enough that it can run on user systems when those users upgrade; we usually recommend leaving such fixes in place for one year.
